Workaround platform differences in svg/text/combining-character-queries.html (2)

Workaround platform differences in svg/text/combining-character-queries.html (2)

This is a followup to [1] which failed to fix MacOS differences [2] in
glyphs with two diacritics. This patch skips the failing part of the test
entirely.

[1] https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb8805eb9ec137fe
[2] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showExpectations=true&tests=svg%2Ftext%2Fcombining-character-queries.html

BUG=669693
Review-Url: https://codereview.chromium.org/2650353005
Cr-Commit-Position: refs/heads/master@{#446197}
Committed: https://chromium.googlesource.com/chromium/src/+/cf750a021a4e265f90b2d4a30db7cba0eb216d80

[pdr., 2017-01-25 18:51:04]

Description was changed from

==========
sfd

BUG=
==========

to

==========
Workaround platform differences in svg/text/combining-character-queries.html (2)

This is a followup to [1] which failed to fix MacOS differences [2] in
glyphs with two diacritics. This patch skips the failing part of the test
entirely.

[1]
https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb88...
[2]
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=669693
==========

[pdr., 2017-01-25 18:51:04]

pdr@chromium.org changed reviewers:
+ fs@opera.com

[pdr., 2017-01-25 20:58:06]

Even though the test passed every mac trybot, it still failed on the Mac
RandomOrder bot for diacritics and I was able to confirm this locally :/ This is
unrelated to running the test in random order. I think it's best to just skip
this subtest while maintaining test coverage in the rest of the test.

[fs, 2017-01-25 21:03:31]

On 2017/01/25 at 20:58:06, pdr wrote:
> Even though the test passed every mac trybot, it still failed on the Mac
RandomOrder bot for diacritics and I was able to confirm this locally :/ This is
unrelated to running the test in random order. I think it's best to just skip
this subtest while maintaining test coverage in the rest of the test.

Second time's the charm. LGTM.

[pdr., 2017-01-26 00:32:26]

On 2017/01/25 at 21:03:31, fs wrote:
> On 2017/01/25 at 20:58:06, pdr wrote:
> > Even though the test passed every mac trybot, it still failed on the Mac
RandomOrder bot for diacritics and I was able to confirm this locally :/ This is
unrelated to running the test in random order. I think it's best to just skip
this subtest while maintaining test coverage in the rest of the test.
> 
> Second time's the charm. LGTM.

I just double-checked this on MacOS on a machine this test previously failed on,
so I think we're good to go this time.

[pdr., 2017-01-26 00:32:41]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-01-26 00:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 01:41:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485390761025410,
"parent_rev": "b07e16045b933d06587a8483731ffae24e21e6a3", "commit_rev":
"cf750a021a4e265f90b2d4a30db7cba0eb216d80"}

[commit-bot: I haz the power, 2017-01-26 01:41:45]

Description was changed from

==========
Workaround platform differences in svg/text/combining-character-queries.html (2)

This is a followup to [1] which failed to fix MacOS differences [2] in
glyphs with two diacritics. This patch skips the failing part of the test
entirely.

[1]
https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb88...
[2]
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=669693
==========

to

==========
Workaround platform differences in svg/text/combining-character-queries.html (2)

This is a followup to [1] which failed to fix MacOS differences [2] in
glyphs with two diacritics. This patch skips the failing part of the test
entirely.

[1]
https://chromium.googlesource.com/chromium/src/+/eb52fcf8c84eb033f63d2839eb88...
[2]
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

BUG=669693

Review-Url: https://codereview.chromium.org/2650353005
Cr-Commit-Position: refs/heads/master@{#446197}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf750a021a4e265f90b2d4a30db7...
==========

[commit-bot: I haz the power, 2017-01-26 01:41:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf750a021a4e265f90b2d4a30db7...