[foozzie] Fix mock variables that leaked into the global object

[foozzie] Fix mock variables that leaked into the global object

Also tidy some JS style in the file.

BUG=chromium:673246
NOTRY=true

Review-Url: https://codereview.chromium.org/2650353004
Cr-Commit-Position: refs/heads/master@{#42659}
Committed: https://chromium.googlesource.com/v8/v8/+/7c30fcf22dfd3a22874b4525bcfbe59e8786635b

[Michael Achenbach, 2017-01-25 14:23:19]

Description was changed from

==========
[foozzie] Fix mock variables that leaked into the global object

BUG=
==========

to

==========
[foozzie] Fix mock variables that leaked into the global object

Also tidy some JS style in the file.

BUG=chromium:673246
NOTRY=true
==========

[Michael Achenbach, 2017-01-25 14:25:44]

machenbach@chromium.org changed reviewers:
+ jarin@chromium.org, mstarzinger@chromium.org

[Michael Achenbach, 2017-01-25 14:25:45]

PTAL

https://codereview.chromium.org/2650353004/diff/1/tools/foozzie/v8_mock.js
File tools/foozzie/v8_mock.js (left):

https://codereview.chromium.org/2650353004/diff/1/tools/foozzie/v8_mock.js#ol...
tools/foozzie/v8_mock.js:18: Object.prototype.mock_arguments = ['x', 'y']
This is unused. The 2-3 test cases that lead to f.arguments errors are
blacklisted.

https://codereview.chromium.org/2650353004/diff/1/tools/foozzie/v8_mock.js
File tools/foozzie/v8_mock.js (right):

https://codereview.chromium.org/2650353004/diff/1/tools/foozzie/v8_mock.js#ne...
tools/foozzie/v8_mock.js:17: var index = 0
I shortened all these cryptic variable names.

[Michael Starzinger, 2017-01-25 14:55:31]

LGTM.

[Michael Achenbach, 2017-01-25 14:57:57]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:58:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 14:59:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485356277275740, "parent_rev":
"1c1742f38d457700ce11674104b4e352187c1b4c", "commit_rev":
"7c30fcf22dfd3a22874b4525bcfbe59e8786635b"}

[commit-bot: I haz the power, 2017-01-25 14:59:46]

Description was changed from

==========
[foozzie] Fix mock variables that leaked into the global object

Also tidy some JS style in the file.

BUG=chromium:673246
NOTRY=true
==========

to

==========
[foozzie] Fix mock variables that leaked into the global object

Also tidy some JS style in the file.

BUG=chromium:673246
NOTRY=true

Review-Url: https://codereview.chromium.org/2650353004
Cr-Commit-Position: refs/heads/master@{#42659}
Committed:
https://chromium.googlesource.com/v8/v8/+/7c30fcf22dfd3a22874b4525bcfbe59e878...
==========

[commit-bot: I haz the power, 2017-01-25 14:59:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c30fcf22dfd3a22874b4525bcfbe59e878...