Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
index 161f9786cb93e753a2bf908d47b81f734ff7ef67..5f34430486001a3e926872eba550b5247a41efc5 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
@@ -49,6 +49,7 @@ class Page;
class PaintLayer;
class Region;
class ScrollableArea;
+class ProgrammaticScrollCoordinator;
class WebLayerTreeView;
class WebScrollbarLayer;
@@ -134,6 +135,8 @@ class CORE_EXPORT ScrollingCoordinator final
return m_programmaticScrollAnimatorTimeline.get();
}
+ ProgrammaticScrollCoordinator* programmaticScrollCoordinator();
+
// For testing purposes only. This ScrollingCoordinator is reused between
// layout test, and must be reset for the results to be valid.
void reset();
@@ -186,6 +189,8 @@ class CORE_EXPORT ScrollingCoordinator final
bool m_wasFrameScrollable;
MainThreadScrollingReasons m_lastMainThreadScrollingReasons;
+
+ Member<ProgrammaticScrollCoordinator> m_programmaticScrollCoordinator;
bokan 2017/02/21 21:33:01 What should happen if two separate scrollable DIVs
sunyunjia 2017/02/24 19:11:48 Well, on a second thought, there might be conflict
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698