Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Revised according to the comments. We are still missing tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index b32feec3fc12bd33516f86f21e7ccee499324044..1a1f0cdf4ecdf3419f75746ef183da97b8ad70cf 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -105,6 +105,7 @@ DEFINE_TRACE(ScrollingCoordinator) {
visitor->trace(m_page);
visitor->trace(m_horizontalScrollbars);
visitor->trace(m_verticalScrollbars);
+ visitor->trace(m_programmaticScrollCoordinator);
}
void ScrollingCoordinator::setShouldHandleScrollGestureOnMainThreadRegion(
@@ -1164,4 +1165,13 @@ bool ScrollingCoordinator::frameViewIsDirty() const {
return false;
}
+ProgrammaticScrollCoordinator*
+ScrollingCoordinator::programmaticScrollCoordinator() {
+ if (!m_programmaticScrollCoordinator) {
+ m_programmaticScrollCoordinator = ProgrammaticScrollCoordinator::create();
+ }
+
+ return m_programmaticScrollCoordinator.get();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698