Clean up param validation in browsing_data_api.cc

Clean up param validation in browsing_data_api.cc

Instead of manually setting and reading ExtensionFunction::bad_message_,
use EXTENSION_FUNCTION_VALIDATE from ::Run*.

Remove ExtensionFunction::bad_message() since it will no longer be used.

BUG=648275
Test=None, refactor change.

Review-Url: https://codereview.chromium.org/2650343005
Cr-Commit-Position: refs/heads/master@{#446139}
Committed: https://chromium.googlesource.com/chromium/src/+/c9106745093e61a44cd3a0f6125dca4ddf8708ca

[lazyboy, 2017-01-25 19:23:23]

Description was changed from

==========
Clean up param validation in browsing_data_api.cc

Instead of manually setting and reading ExtensionFunction::bad_message_,
use EXTENSION_FUNCTION_VALIDATE from ::Run*.

Remove ExtensionFunction::bad_message() since it will no longer be used.

BUG=
==========

to

==========
Clean up param validation in browsing_data_api.cc

Instead of manually setting and reading ExtensionFunction::bad_message_,
use EXTENSION_FUNCTION_VALIDATE from ::Run*.

Remove ExtensionFunction::bad_message() since it will no longer be used.

BUG=648275
Test=None, refactor change.
==========

[lazyboy, 2017-01-25 19:23:26]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[lazyboy, 2017-01-25 19:23:34]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-01-25 19:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-01-25 20:21:27]

lgtm

https://codereview.chromium.org/2650343005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/browsing_data/browsing_data_api.h (right):

https://codereview.chromium.org/2650343005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/browsing_data/browsing_data_api.h:104: // should
be returned in |removal_mask|.
nitty nit: second sentence should be something like "|removal_mask| is populated
with the result, if successful" - comments shouldn't say things like "should"
when it comes to function behavior if we can help it. :)

[commit-bot: I haz the power, 2017-01-25 20:22:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 20:22:48]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-01-25 21:09:30]

https://codereview.chromium.org/2650343005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/browsing_data/browsing_data_api.h (right):

https://codereview.chromium.org/2650343005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/browsing_data/browsing_data_api.h:104: // should
be returned in |removal_mask|.
On 2017/01/25 20:21:26, Devlin (catching up) wrote:
> nitty nit: second sentence should be something like "|removal_mask| is
populated
> with the result, if successful" - comments shouldn't say things like "should"
> when it comes to function behavior if we can help it. :)

Done.

[lazyboy, 2017-01-25 21:09:40]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2017-01-25 21:09:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2650343005/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-01-25 21:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:09:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485378580207690,
"parent_rev": "ec16bb52500466f1aa41eb4b513e8c2d3290e833", "commit_rev":
"c9106745093e61a44cd3a0f6125dca4ddf8708ca"}

[commit-bot: I haz the power, 2017-01-25 22:10:15]

Description was changed from

==========
Clean up param validation in browsing_data_api.cc

Instead of manually setting and reading ExtensionFunction::bad_message_,
use EXTENSION_FUNCTION_VALIDATE from ::Run*.

Remove ExtensionFunction::bad_message() since it will no longer be used.

BUG=648275
Test=None, refactor change.
==========

to

==========
Clean up param validation in browsing_data_api.cc

Instead of manually setting and reading ExtensionFunction::bad_message_,
use EXTENSION_FUNCTION_VALIDATE from ::Run*.

Remove ExtensionFunction::bad_message() since it will no longer be used.

BUG=648275
Test=None, refactor change.

Review-Url: https://codereview.chromium.org/2650343005
Cr-Commit-Position: refs/heads/master@{#446139}
Committed:
https://chromium.googlesource.com/chromium/src/+/c9106745093e61a44cd3a0f6125d...
==========

[commit-bot: I haz the power, 2017-01-25 22:10:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c9106745093e61a44cd3a0f6125d...