Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2650303002: cc: Remove the LayerTreeHost abstraction. (Closed)

Created:
3 years, 11 months ago by Khushal
Modified:
3 years, 11 months ago
Reviewers:
danakj, pdr., boliu, enne (OOO)
CC:
blink-reviews, cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, mlamouri+watch-content_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove the LayerTreeHost abstraction. The LayerTreeHost abstraction and InProcess implementation was added to allow blimp to provide a remote implementation. This is no longer needed so the patch reverts the abstraction to make LayerTreeHost concrete again and renames LTHInProcess back to LTH. BUG=682436 TBR=pdr@chromium.org, danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2650303002 Cr-Commit-Position: refs/heads/master@{#445927} Committed: https://chromium.googlesource.com/chromium/src/+/e0e4486e66cb8c74dc8616373b1cf598dfca3fe6

Patch Set 1 #

Patch Set 2 : missed ui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -1373 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/layer_unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/surfaces/surface_reference_owner.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 4 chunks +10 lines, -10 lines 0 comments Download
M cc/test/fake_layer_tree_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.h View 3 chunks +1 line, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 8 chunks +16 lines, -28 lines 0 comments Download
M cc/trees/layer_tree_host.h View 3 chunks +266 lines, -68 lines 0 comments Download
A + cc/trees/layer_tree_host.cc View 27 chunks +82 lines, -82 lines 0 comments Download
D cc/trees/layer_tree_host_in_process.h View 1 chunk +0 lines, -291 lines 0 comments Download
D cc/trees/layer_tree_host_in_process.cc View 1 chunk +0 lines, -815 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/trees/proxy_impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/proxy_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/proxy_main.h View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
Khushal
3 years, 11 months ago (2017-01-24 22:11:54 UTC) #3
Khushal
enne for cc/ and content/renderer pdr for Webkit boliu for content/browser
3 years, 11 months ago (2017-01-24 22:13:20 UTC) #5
enne (OOO)
lgtm
3 years, 11 months ago (2017-01-24 22:21:21 UTC) #6
boliu
lgtm
3 years, 11 months ago (2017-01-24 22:37:58 UTC) #7
Khushal
TBRing pdr@, since its just a rename.
3 years, 11 months ago (2017-01-24 23:50:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650303002/1
3 years, 11 months ago (2017-01-24 23:51:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/199362) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-25 00:05:56 UTC) #14
Khushal
+danakj TBR for ui/
3 years, 11 months ago (2017-01-25 00:12:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650303002/20001
3 years, 11 months ago (2017-01-25 00:13:49 UTC) #20
pdr.
This abstraction took me quite a long time to figure out, so I really like ...
3 years, 11 months ago (2017-01-25 00:30:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/298991)
3 years, 11 months ago (2017-01-25 01:45:42 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650303002/20001
3 years, 11 months ago (2017-01-25 01:54:39 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e0e4486e66cb8c74dc8616373b1cf598dfca3fe6
3 years, 11 months ago (2017-01-25 03:15:40 UTC) #28
danakj
3 years, 11 months ago (2017-01-25 15:57:42 UTC) #29
Message was sent while issue was closed.
ui LGTM

Powered by Google App Engine
This is Rietveld 408576698