Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2650273006: Make enabling of CSA verifier a build-time flag (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make enabling of CSA verifier a build-time flag BUG=chromium:685561 Review-Url: https://codereview.chromium.org/2650273006 Cr-Commit-Position: refs/heads/master@{#42734} Committed: https://chromium.googlesource.com/v8/v8/+/53445715805fdfa5a3fa02cf68ce6adb79b87b1c

Patch Set 1 #

Patch Set 2 : New version #

Patch Set 3 : Rename #

Patch Set 4 : Make it work #

Patch Set 5 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -8 lines) Patch
M BUILD.gn View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M Makefile View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M gypfiles/features.gypi View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 2 3 4 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
danno
ptal
3 years, 11 months ago (2017-01-26 13:15:35 UTC) #14
Michael Achenbach
gn/gyp configs lgtm
3 years, 11 months ago (2017-01-26 13:26:36 UTC) #15
epertoso
lgtm, thanks!
3 years, 10 months ago (2017-01-27 11:24:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650273006/80001
3 years, 10 months ago (2017-01-27 11:25:55 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 11:32:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/53445715805fdfa5a3fa02cf68ce6adb79b...

Powered by Google App Engine
This is Rietveld 408576698