Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2650273004: Float layer should ignore offsets from ancestor inline layers under containing block (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Float layer should ignore offsets from ancestor inline layers under containing block - When calculating layer location, we should traverse containers instead of parents, because containers instead of parents affect locations of children. This ensures we get correct location for floating layer. - When calculating layer offset in an ancestor, for a float layer, we should skip inline ancestors below the containing block. BUG=683576 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2647383004 Cr-Original-Commit-Position: refs/heads/master@{#445592} Review-Url: https://codereview.chromium.org/2650273004 Cr-Commit-Position: refs/branch-heads/2987@{#88} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/0978e4af69ab13578b22b75539038263a3e8df3a

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650273004/1
3 years, 11 months ago (2017-01-25 17:52:29 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-25 17:52:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650273004/1
3 years, 11 months ago (2017-01-25 17:56:18 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 18:04:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0978e4af69ab13578b22b7553903...

Powered by Google App Engine
This is Rietveld 408576698