Media Remoting: Add unittests for RPC converters.

Media Remoting: Add unittests for RPC converters.

Add unittests to those converters that were not tested.

BUG=643964
Review-Url: https://codereview.chromium.org/2650243004
Cr-Commit-Position: refs/heads/master@{#446187}
Committed: https://chromium.googlesource.com/chromium/src/+/c6e43b7acabc17ec431debcad4228cc950166f1b

[xjz, 2017-01-25 01:53:24]

The CQ bit was checked by xjz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xjz, 2017-01-25 01:55:43]

xjz@chromium.org changed reviewers:
+ miu@chromium.org

[xjz, 2017-01-25 01:55:43]

PTAL

[commit-bot: I haz the power, 2017-01-25 03:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 03:06:17]

Dry run: This issue passed the CQ dry run.

[miu, 2017-01-25 23:53:34]

lgtm % one thing:

https://codereview.chromium.org/2650243004/diff/1/media/remoting/proto_utils_...
File media/remoting/proto_utils_unittest.cc (right):

https://codereview.chromium.org/2650243004/diff/1/media/remoting/proto_utils_...
media/remoting/proto_utils_unittest.cc:204:
ConvertCdmPromiseWithCdmIdToProto(success_result, kCdmId, promise_message);
Before calling the second converter, reset the |output_result|:

  output_result = CdmPromiseResult();

That way, if there are some fields the second converter function doesn't
populate, we will detect that.

[xjz, 2017-01-26 00:03:31]

Addressed comments. Thanks!

https://codereview.chromium.org/2650243004/diff/1/media/remoting/proto_utils_...
File media/remoting/proto_utils_unittest.cc (right):

https://codereview.chromium.org/2650243004/diff/1/media/remoting/proto_utils_...
media/remoting/proto_utils_unittest.cc:204:
ConvertCdmPromiseWithCdmIdToProto(success_result, kCdmId, promise_message);
On 2017/01/25 23:53:34, miu wrote:
> Before calling the second converter, reset the |output_result|:
> 
>   output_result = CdmPromiseResult();
> 
> That way, if there are some fields the second converter function doesn't
> populate, we will detect that.

Done.

[xjz, 2017-01-26 00:03:37]

The CQ bit was checked by xjz@chromium.org

[xjz, 2017-01-26 00:03:37]

The patchset sent to the CQ was uploaded after l-g-t-m from miu@chromium.org
Link to the patchset: https://codereview.chromium.org/2650243004/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-01-26 00:04:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 01:14:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485389017085250,
"parent_rev": "ad475ed683320a15232dc23b6e933012c1a7c2fa", "commit_rev":
"c6e43b7acabc17ec431debcad4228cc950166f1b"}

[commit-bot: I haz the power, 2017-01-26 01:15:42]

Description was changed from

==========
Media Remoting: Add unittests for RPC converters.

Add unittests to those converters that were not tested.

BUG=643964
==========

to

==========
Media Remoting: Add unittests for RPC converters.

Add unittests to those converters that were not tested.

BUG=643964

Review-Url: https://codereview.chromium.org/2650243004
Cr-Commit-Position: refs/heads/master@{#446187}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6e43b7acabc17ec431debcad422...
==========

[commit-bot: I haz the power, 2017-01-26 01:15:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c6e43b7acabc17ec431debcad422...