Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2650213004: [Android NTP] Notify about correct number of removed suggestions when clearing all but first N noti… (Closed)

Created:
3 years, 11 months ago by Bernhard Bauer
Modified:
3 years, 10 months ago
Reviewers:
jkrcal, dgn
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android NTP] Notify about correct number of removed suggestions when clearing all but first N notifications in SuggestionList Also, verify interactions with the section's parent in SuggestionsSectionTest. Review-Url: https://codereview.chromium.org/2650213004 Cr-Commit-Position: refs/heads/master@{#446371} Committed: https://chromium.googlesource.com/chromium/src/+/f9c23d19b826fc1e0cc587bcaad3f04968e3a62e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 1 2 3 chunks +2 lines, -13 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 1 2 16 chunks +34 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (12 generated)
Bernhard Bauer
Please review. Thanks!
3 years, 11 months ago (2017-01-26 14:07:35 UTC) #10
jkrcal
lgtm, thanks!
3 years, 11 months ago (2017-01-26 14:28:27 UTC) #11
dgn
lgtm
3 years, 11 months ago (2017-01-26 15:23:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650213004/40001
3 years, 11 months ago (2017-01-26 16:41:22 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 17:48:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f9c23d19b826fc1e0cc587bcaad3...

Powered by Google App Engine
This is Rietveld 408576698