Remove spelling markers when element is not editable

third_party/WebKit/Source/core/html/HTMLElement.cpp

Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index deaffb100f9afb20f25292e1f32f9b3112c24a82..db0475ac66ca4161a4c181a8a4b0a9d7804cbf9c 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -46,6 +46,7 @@
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/serializers/Serialization.h"
+#include "core/editing/spellcheck/SpellChecker.h"
 #include "core/events/EventListener.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/frame/Settings.h"
@@ -436,6 +437,8 @@ void HTMLElement::attributeChanged(const AttributeModificationParams& params) {
     if (adjustedFocusedElementInTreeScope() == this)
       blur();
   } else if (params.name == contenteditableAttr) {
+    if (!isEditable(*this))

[Xiaocheng, 2017/01/26 05:12:33]

Please do not use |isEditable| inside Blink. Instead, this part should be

// TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited.  See http://crbug.com/590369 for more details.
document().updateStyleAndLayoutTreeForNode(this);

if (!hasEditableStyle(*this))
  document().frame()->spellChecker().removeSpellingAndGrammarMarkers(*this);


For some historical reasons, Blink is using a style-based editability system,
which is not quite spec-compatible. We are working on making it compatible,
though...

Blink also implements a spec-compatible
|Element::isContentEditableForBinding()|, which is, however, a fake function
only for Web API, and is not supposed to be used inside Blink.
|isEditable(Node&)| is a helper function for |isContentEditableForBinding|, and
should not be used internally, either.

+      document().frame()->spellChecker().removeSpellingAndGrammarMarkers(*this);
     if (adjustedFocusedElementInTreeScope() != this)
       return;
     // The attribute change may cause supportsFocus() to return false