Remove spelling markers when element is not editable

third_party/WebKit/Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 28 matching lines @@
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/NodeTraversal.h"
 #include "core/dom/StyleChangeReason.h"
 #include "core/dom/Text.h"
 #include "core/dom/shadow/ElementShadow.h"
 #include "core/dom/shadow/FlatTreeTraversal.h"
 #include "core/dom/shadow/ShadowRoot.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/serializers/Serialization.h"
+#include "core/editing/spellcheck/SpellChecker.h"
 #include "core/events/EventListener.h"
 #include "core/events/KeyboardEvent.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/HTMLBRElement.h"
 #include "core/html/HTMLDimension.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLMenuElement.h"
 #include "core/html/HTMLTemplateElement.h"
@@ skipping 370 matching lines @@
 void HTMLElement::attributeChanged(const AttributeModificationParams& params) {
   Element::attributeChanged(params);
   if (params.reason != AttributeModificationReason::kDirectly)
     return;
   // adjustedFocusedElementInTreeScope() is not trivial. We should check
   // attribute names, then call adjustedFocusedElementInTreeScope().
   if (params.name == hiddenAttr && !params.newValue.isNull()) {
     if (adjustedFocusedElementInTreeScope() == this)
       blur();
   } else if (params.name == contenteditableAttr) {
+    if (!isEditable(*this))

[Xiaocheng, 2017/01/26 05:12:33]

Please do not use |isEditable| inside Blink. Instead, this part should be

// TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
// needs to be audited.  See http://crbug.com/590369 for more details.
document().updateStyleAndLayoutTreeForNode(this);

if (!hasEditableStyle(*this))
  document().frame()->spellChecker().removeSpellingAndGrammarMarkers(*this);


For some historical reasons, Blink is using a style-based editability system,
which is not quite spec-compatible. We are working on making it compatible,
though...

Blink also implements a spec-compatible
|Element::isContentEditableForBinding()|, which is, however, a fake function
only for Web API, and is not supposed to be used inside Blink.
|isEditable(Node&)| is a helper function for |isContentEditableForBinding|, and
should not be used internally, either.

+      document().frame()->spellChecker().removeSpellingAndGrammarMarkers(*this);
     if (adjustedFocusedElementInTreeScope() != this)
       return;
     // The attribute change may cause supportsFocus() to return false
     // for the element which had focus.
     //
     // TODO(tkent): We should avoid updating style.  We'd like to check only
     // DOM-level focusability here.
     document().updateStyleAndLayoutTreeForNode(this);
     if (!supportsFocus())
       blur();
@@ skipping 766 matching lines @@
 
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(blink::HTMLElement*);
 
 void dumpInnerHTML(blink::HTMLElement* element) {
   printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif