Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2650153003: Add constructors and operators to MediaDeviceInfo. (Closed)

Created:
3 years, 11 months ago by Guido Urdaneta
Modified:
3 years, 11 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add constructors and operators to MediaDeviceInfo. The context for this is to better support getUserMedia features such as constraints and spec-compliant device selection. BUG=657733 Review-Url: https://codereview.chromium.org/2650153003 Cr-Commit-Position: refs/heads/master@{#445774} Committed: https://chromium.googlesource.com/chromium/src/+/89f261bcbcfa23d14ac1362a600784ce1d75f3e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -4 lines) Patch
M content/browser/renderer_host/media/media_devices_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/media/media_devices.h View 2 chunks +9 lines, -2 lines 0 comments Download
M content/common/media/media_devices.cc View 2 chunks +18 lines, -0 lines 0 comments Download
A content/common/media/media_devices_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
Guido Urdaneta
Hi, PTAL
3 years, 11 months ago (2017-01-24 14:43:49 UTC) #3
tommi (sloooow) - chröme
lgtm
3 years, 11 months ago (2017-01-24 17:40:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650153003/20001
3 years, 11 months ago (2017-01-24 17:41:19 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 19:14:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89f261bcbcfa23d14ac1362a6007...

Powered by Google App Engine
This is Rietveld 408576698