mus: Make sure WindowCompositorFrameSink is detached correctly.

mus: Make sure WindowCompositorFrameSink is detached correctly.

WindowCompositorFrameSink is detached from the client on the same thread
it is attached to the client, which can be different from the thread it
is created/destroyed on. So, all the thread-hostile objects created
during attachment (i.e. in BindToClient()) needs to be destroyed during
detach (i.e. in DetachFromClient()), because otherwise they will be
destroyed during the destruction of a WindowCompositorFrameSink on a
different thread, causing crashes etc. |client_binding_| is such a
thread-hostile object, so make sure it is destroyed during detach.

BUG=672913
Review-Url: https://codereview.chromium.org/2650123002
Cr-Commit-Position: refs/heads/master@{#445761}
Committed: https://chromium.googlesource.com/chromium/src/+/5c0ead04050ee0787ef0d9af45efc3c740571465

[sadrul, 2017-01-24 02:28:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 02:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-24 02:33:44]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[Fady Samuel, 2017-01-24 02:34:47]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-01-24 02:34:47]

Drive-by LGTM. Also, can I have OWNERship of this file?

[commit-bot: I haz the power, 2017-01-24 03:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 03:22:42]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-24 17:46:44]

LGTM

[sadrul, 2017-01-24 17:47:04]

On 2017/01/24 02:34:47, Fady Samuel wrote:
> Drive-by LGTM. Also, can I have OWNERship of this file?

Done in https://codereview.chromium.org/2649353005/. With that, putting this one
in the CQ

[sadrul, 2017-01-24 18:10:02]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:10:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 18:15:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485281402612930, "parent_rev":
"92bce5eb5a81dd0ed238621622c9ace5e2a36f7c", "commit_rev":
"5c0ead04050ee0787ef0d9af45efc3c740571465"}

[commit-bot: I haz the power, 2017-01-24 18:16:16]

Description was changed from

==========
mus: Make sure WindowCompositorFrameSink is detached correctly.

WindowCompositorFrameSink is detached from the client on the same thread
it is attached to the client, which can be different from the thread it
is created/destroyed on. So, all the thread-hostile objects created
during attachment (i.e. in BindToClient()) needs to be destroyed during
detach (i.e. in DetachFromClient()), because otherwise they will be
destroyed during the destruction of a WindowCompositorFrameSink on a
different thread, causing crashes etc. |client_binding_| is such a
thread-hostile object, so make sure it is destroyed during detach.

BUG=672913
==========

to

==========
mus: Make sure WindowCompositorFrameSink is detached correctly.

WindowCompositorFrameSink is detached from the client on the same thread
it is attached to the client, which can be different from the thread it
is created/destroyed on. So, all the thread-hostile objects created
during attachment (i.e. in BindToClient()) needs to be destroyed during
detach (i.e. in DetachFromClient()), because otherwise they will be
destroyed during the destruction of a WindowCompositorFrameSink on a
different thread, causing crashes etc. |client_binding_| is such a
thread-hostile object, so make sure it is destroyed during detach.

BUG=672913

Review-Url: https://codereview.chromium.org/2650123002
Cr-Commit-Position: refs/heads/master@{#445761}
Committed:
https://chromium.googlesource.com/chromium/src/+/5c0ead04050ee0787ef0d9af45ef...
==========

[commit-bot: I haz the power, 2017-01-24 18:16:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c0ead04050ee0787ef0d9af45ef...