Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Remove logging statements, fix copyright years in new files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index 1267adb057141c2533062ab02a2a0faa9dd91a9c..dc4184dbbeeca6ef7b2ee398bf7ac3e011d538d4 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -1973,7 +1973,7 @@ bool FrameView::computeCompositedSelection(LocalFrame& frame,
return false;
const VisibleSelection& visibleSelection = frame.selection().selection();
- if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
+ if (visibleSelection.isNone())
rlanday 2017/01/31 19:50:22 I'm going to undo the changes to this file, I was
return false;
// Non-editable caret selections lack any kind of UI affordance, and
@@ -2041,8 +2041,9 @@ void FrameView::updateCompositedSelectionIfNeeded() {
localFrame = m_frame->localFrameRoot();
}
- if (localFrame)
+ if (localFrame) {
page->chromeClient().clearCompositedSelection(localFrame);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698