[WIP] Add support for Android SuggestionSpans when editing text

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 1955 matching lines @@
       layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
   }
 }
 
 bool FrameView::computeCompositedSelection(LocalFrame& frame,
                                            CompositedSelection& selection) {
   if (!frame.view() || frame.view()->shouldThrottleRendering())
     return false;
 
   const VisibleSelection& visibleSelection = frame.selection().selection();
-  if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
+  if (visibleSelection.isNone())

[rlanday, 2017/01/31 19:50:22]

I'm going to undo the changes to this file, I was testing if we wanted to hide
the blue selection handle when the suggestion menu opens, but it didn't really
look any better when I did that because the selection still jumps around

     return false;
 
   // Non-editable caret selections lack any kind of UI affordance, and
   // needn't be tracked by the client.
   if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
     return false;
 
   VisiblePosition visibleStart(visibleSelection.visibleStart());
   RenderedPosition renderedStart(visibleStart);
   renderedStart.positionInGraphicsLayerBacking(selection.start, true);
@@ skipping 47 matching lines @@
     if (!localFrame) {
       // Clearing the mainframe when there is no focused frame (and hence
       // no localFrame) is legacy behaviour, and implemented here to
       // satisfy ParameterizedWebFrameTest.CompositedSelectionBoundsCleared's
       // first check that the composited selection has been cleared even
       // though no frame has focus yet. If this is not desired, then the
       // expectation needs to be removed from the test.
       localFrame = m_frame->localFrameRoot();
     }
 
-    if (localFrame)
+    if (localFrame) {
       page->chromeClient().clearCompositedSelection(localFrame);
+    }
   }
 }
 
 HostWindow* FrameView::getHostWindow() const {
   Page* page = frame().page();
   if (!page)
     return nullptr;
   return &page->chromeClient();
 }
 
@@ skipping 3028 matching lines @@
     std::unique_ptr<CompositorAnimationTimeline> timeline) {
   m_animationTimeline = std::move(timeline);
 }
 
 void FrameView::setAnimationHost(
     std::unique_ptr<CompositorAnimationHost> host) {
   m_animationHost = std::move(host);
 }
 
 }  // namespace blink