Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/core/editing/CompositionUnderline.h

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Remove logging statements, fix copyright years in new files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CompositionUnderline.h
diff --git a/third_party/WebKit/Source/core/editing/CompositionUnderline.h b/third_party/WebKit/Source/core/editing/CompositionUnderline.h
index fc91fe8ddff087310907d68d21b4d6e1a0c924f1..d522479fb0dca78ff2ff7adc9495d0985cc82fa8 100644
--- a/third_party/WebKit/Source/core/editing/CompositionUnderline.h
+++ b/third_party/WebKit/Source/core/editing/CompositionUnderline.h
@@ -29,6 +29,7 @@
#include "core/CoreExport.h"
#include "platform/graphics/Color.h"
#include "wtf/Allocator.h"
+#include <vector>
namespace blink {
@@ -41,12 +42,19 @@ class CORE_EXPORT CompositionUnderline {
const Color&,
bool thick,
const Color& backgroundColor);
+ CompositionUnderline(unsigned startOffset,
+ unsigned endOffset,
+ const Color&,
+ bool thick,
+ const Color& backgroundColor,
+ const std::vector<std::string>& suggestions);
unsigned startOffset() const { return m_startOffset; }
unsigned endOffset() const { return m_endOffset; }
const Color& color() const { return m_color; }
bool thick() const { return m_thick; }
const Color& backgroundColor() const { return m_backgroundColor; }
+ const std::vector<std::string>& suggestions() const { return m_suggestions; }
private:
unsigned m_startOffset;
@@ -54,6 +62,7 @@ class CORE_EXPORT CompositionUnderline {
Color m_color;
bool m_thick;
Color m_backgroundColor;
+ std::vector<std::string> m_suggestions;
esprehn 2017/01/31 22:41:34 no std:: in blink. This should be Vector<String>
rlanday 2017/01/31 23:30:09 Ok
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698