Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/Source/core/editing/CompositionUnderline.cpp

Issue 2650113004: [WIP] Add support for Android SuggestionSpans when editing text (Closed)
Patch Set: Remove logging statements, fix copyright years in new files Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/CompositionUnderline.cpp
diff --git a/third_party/WebKit/Source/core/editing/CompositionUnderline.cpp b/third_party/WebKit/Source/core/editing/CompositionUnderline.cpp
index e404879b86ccb7b461d896f3eaeda749d8783b57..027ccce6d945bc6019cd3ee9539561c22822a0bd 100644
--- a/third_party/WebKit/Source/core/editing/CompositionUnderline.cpp
+++ b/third_party/WebKit/Source/core/editing/CompositionUnderline.cpp
@@ -11,7 +11,24 @@ CompositionUnderline::CompositionUnderline(unsigned startOffset,
const Color& color,
bool thick,
const Color& backgroundColor)
- : m_color(color), m_thick(thick), m_backgroundColor(backgroundColor) {
+ : CompositionUnderline(startOffset,
+ endOffset,
+ color,
+ thick,
+ backgroundColor,
+ std::vector<std::string>()) {}
+
+CompositionUnderline::CompositionUnderline(
+ unsigned startOffset,
+ unsigned endOffset,
+ const Color& color,
+ bool thick,
+ const Color& backgroundColor,
+ const std::vector<std::string>& suggestions)
+ : m_color(color),
+ m_thick(thick),
+ m_backgroundColor(backgroundColor),
+ m_suggestions(suggestions) {
// Sanitize offsets by ensuring a valid range corresponding to the last
// possible position.
// TODO(wkorman): Consider replacing with DCHECK_LT(startOffset, endOffset).

Powered by Google App Engine
This is Rietveld 408576698