Fix Thread::StopSoon() documentation.

Fix Thread::StopSoon() documentation.

It definitely can and ThreadTest.StopTwiceNop even exercises precisely
doing that.

BUG=629139
Review-Url: https://codereview.chromium.org/2650073004
Cr-Commit-Position: refs/heads/master@{#446116}
Committed: https://chromium.googlesource.com/chromium/src/+/fc17e28f48e807564535c1447075656e622094a1

[gab, 2017-01-24 21:25:24]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-01-24 21:25:33]

gab@chromium.org changed reviewers:
+ danakj@chromium.org

[gab, 2017-01-24 21:25:33]

Dana PTAL

[commit-bot: I haz the power, 2017-01-24 21:25:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-24 22:35:30]

LGTM

[commit-bot: I haz the power, 2017-01-24 22:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:44:22]

Dry run: This issue passed the CQ dry run.

[gab, 2017-01-25 14:48:07]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:48:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 14:52:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:52:40]

Failed to apply patch for base/threading/thread.h:
While running git apply --index -p1;
  error: patch failed: base/threading/thread.h:164
  error: base/threading/thread.h: patch does not apply

Patch:       base/threading/thread.h
Index: base/threading/thread.h
diff --git a/base/threading/thread.h b/base/threading/thread.h
index
f103e3d22881dec0b0c3b6d6cf423f9b812730f8..0575ab4d6ef53df067b4137a1259ee4f3c4ecfa6
100644
--- a/base/threading/thread.h
+++ b/base/threading/thread.h
@@ -164,9 +164,8 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
   // deadlock on Windows with printer worker thread. In any other case, Stop()
   // should be used.
   //
-  // StopSoon should not be called multiple times as it is risky to do so. It
-  // could cause a timing issue in message_loop() access. Call Stop() to reset
-  // the thread object once it is known that the thread has quit.
+  // Call Stop() to reset the thread object once it is known that the thread
has
+  // quit.
   void StopSoon();
 
   // Returns the message loop for this thread.  Use the MessageLoop's

[gab, 2017-01-25 15:04:30]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:04:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 15:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 15:09:14]

Failed to apply patch for base/threading/thread.h:
While running git apply --index -p1;
  error: patch failed: base/threading/thread.h:164
  error: base/threading/thread.h: patch does not apply

Patch:       base/threading/thread.h
Index: base/threading/thread.h
diff --git a/base/threading/thread.h b/base/threading/thread.h
index
f103e3d22881dec0b0c3b6d6cf423f9b812730f8..0575ab4d6ef53df067b4137a1259ee4f3c4ecfa6
100644
--- a/base/threading/thread.h
+++ b/base/threading/thread.h
@@ -164,9 +164,8 @@ class BASE_EXPORT Thread : PlatformThread::Delegate {
   // deadlock on Windows with printer worker thread. In any other case, Stop()
   // should be used.
   //
-  // StopSoon should not be called multiple times as it is risky to do so. It
-  // could cause a timing issue in message_loop() access. Call Stop() to reset
-  // the thread object once it is known that the thread has quit.
+  // Call Stop() to reset the thread object once it is known that the thread
has
+  // quit.
   void StopSoon();
 
   // Returns the message loop for this thread.  Use the MessageLoop's

[gab, 2017-01-25 19:35:17]

The CQ bit was checked by gab@chromium.org

[gab, 2017-01-25 19:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2650073004/#ps20001
(title: "rebase on r446085")

[commit-bot: I haz the power, 2017-01-25 19:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:01:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485372917841550,
"parent_rev": "333889f407e49eca681b3354547221022f4d622c", "commit_rev":
"fc17e28f48e807564535c1447075656e622094a1"}

[commit-bot: I haz the power, 2017-01-25 21:02:30]

Description was changed from

==========
Fix Thread::StopSoon() documentation.

It definitely can and ThreadTest.StopTwiceNop even exercises precisely
doing that.

BUG=629139
==========

to

==========
Fix Thread::StopSoon() documentation.

It definitely can and ThreadTest.StopTwiceNop even exercises precisely
doing that.

BUG=629139

Review-Url: https://codereview.chromium.org/2650073004
Cr-Commit-Position: refs/heads/master@{#446116}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc17e28f48e807564535c1447075...
==========

[commit-bot: I haz the power, 2017-01-25 21:02:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc17e28f48e807564535c1447075...