[wasm] Use ErrorThrower more uniformly in wasm-js.cc

[wasm] Use ErrorThrower more uniformly in wasm-js.cc

R=rossberg@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2650073003
Cr-Commit-Position: refs/heads/master@{#42651}
Committed: https://chromium.googlesource.com/v8/v8/+/1cbb690366f8aa69c18244809ba16d619d84900b

[titzer, 2017-01-24 18:04:23]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 18:04:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 18:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 18:41:56]

Dry run: This issue passed the CQ dry run.

[rossberg, 2017-01-25 09:47:35]

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode116
src/wasm/wasm-js.cc:116: if (has_brand.IsNothing()) return false;
Nit: could similarly combine this into

return !has_brand.IsNothing() && has_brand.ToChecked();

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode120
src/wasm/wasm-js.cc:120: static bool BrandCheck(ErrorThrower* thrower,
i::Handle<i::Object> value,
Why not avoid repetition and simplify this function to

bool result = HasBrand(...);
if (!result) thrower->TypeError(...);
return result;

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode941
src/wasm/wasm-js.cc:941: static bool HasBrand(i::Handle<i::Object> value,
i::Handle<i::Symbol> symbol) {
Why is there another version of HasBrand here?

[titzer, 2017-01-25 09:54:33]

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode116
src/wasm/wasm-js.cc:116: if (has_brand.IsNothing()) return false;
On 2017/01/25 09:47:34, rossberg wrote:
> Nit: could similarly combine this into
> 
> return !has_brand.IsNothing() && has_brand.ToChecked();

Done.

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode120
src/wasm/wasm-js.cc:120: static bool BrandCheck(ErrorThrower* thrower,
i::Handle<i::Object> value,
On 2017/01/25 09:47:34, rossberg wrote:
> Why not avoid repetition and simplify this function to
> 
> bool result = HasBrand(...);
> if (!result) thrower->TypeError(...);
> return result;

Done.

https://codereview.chromium.org/2650073003/diff/1/src/wasm/wasm-js.cc#newcode941
src/wasm/wasm-js.cc:941: static bool HasBrand(i::Handle<i::Object> value,
i::Handle<i::Symbol> symbol) {
On 2017/01/25 09:47:34, rossberg wrote:
> Why is there another version of HasBrand here?

Removed.

[rossberg, 2017-01-25 10:06:02]

LGTM modulo bug

https://codereview.chromium.org/2650073003/diff/20001/src/wasm/wasm-js.cc
File src/wasm/wasm-js.cc (right):

https://codereview.chromium.org/2650073003/diff/20001/src/wasm/wasm-js.cc#new...
src/wasm/wasm-js.cc:120: return HasBrand(value, sym) ? true :
thrower->TypeError("%s", msg), false;
He he, wrong precedence. Why not: HasBrand() || (thrower->TypeError(), false);

[titzer, 2017-01-25 10:09:25]

On 2017/01/25 10:06:02, rossberg wrote:
> LGTM modulo bug
> 
> https://codereview.chromium.org/2650073003/diff/20001/src/wasm/wasm-js.cc
> File src/wasm/wasm-js.cc (right):
> 
>
https://codereview.chromium.org/2650073003/diff/20001/src/wasm/wasm-js.cc#new...
> src/wasm/wasm-js.cc:120: return HasBrand(value, sym) ? true :
> thrower->TypeError("%s", msg), false;
> He he, wrong precedence. Why not: HasBrand() || (thrower->TypeError(), false);

You delight in other's misfortune.

[titzer, 2017-01-25 10:09:31]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-25 10:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2650073003/#ps40001
(title: "Fix precedence")

[commit-bot: I haz the power, 2017-01-25 10:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 10:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485338971115900,
"parent_rev": "8bae36f963a20dad603819bd5901fcf90756d78a", "commit_rev":
"1cbb690366f8aa69c18244809ba16d619d84900b"}

[commit-bot: I haz the power, 2017-01-25 10:40:16]

Description was changed from

==========
[wasm] Use ErrorThrower more uniformly in wasm-js.cc

R=rossberg@chromium.org
BUG=
==========

to

==========
[wasm] Use ErrorThrower more uniformly in wasm-js.cc

R=rossberg@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2650073003
Cr-Commit-Position: refs/heads/master@{#42651}
Committed:
https://chromium.googlesource.com/v8/v8/+/1cbb690366f8aa69c18244809ba16d619d8...
==========

[commit-bot: I haz the power, 2017-01-25 10:40:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/1cbb690366f8aa69c18244809ba16d619d8...