Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2650053005: [wasm-test] WasmModuleBuilder.addCustomSection in the JS builder API. (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm-test] WasmModuleBuilder.addCustomSection in the JS builder API. R=rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2650053005 Cr-Commit-Position: refs/heads/master@{#42655} Committed: https://chromium.googlesource.com/v8/v8/+/f51a5f732c40af6c338956c0682d9dca92d1b34a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M test/mjsunit/wasm/js-api.js View 1 chunk +4 lines, -13 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
3 years, 11 months ago (2017-01-25 10:40:06 UTC) #1
rossberg
lgtm
3 years, 11 months ago (2017-01-25 10:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650053005/1
3 years, 11 months ago (2017-01-25 11:51:12 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 11:53:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f51a5f732c40af6c338956c0682d9dca92d...

Powered by Google App Engine
This is Rietveld 408576698