Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2650033008: Convert TestNavigationObserver to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert TestNavigationObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2650033008 Cr-Commit-Position: refs/heads/master@{#446353} Committed: https://chromium.googlesource.com/chromium/src/+/5c162d76d9db992f4d071b52c63b2a93a21eba8e

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -59 lines) Patch
M content/browser/site_per_process_browsertest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/test/test_navigation_observer.h View 2 chunks +2 lines, -14 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 3 chunks +15 lines, -42 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jam
3 years, 10 months ago (2017-01-26 01:32:16 UTC) #7
nasko
LGTM
3 years, 10 months ago (2017-01-26 14:46:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650033008/20001
3 years, 10 months ago (2017-01-26 15:52:05 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-26 16:47:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5c162d76d9db992f4d071b52c63b...

Powered by Google App Engine
This is Rietveld 408576698