Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2650033002: Move LayoutProgress timer to UnspecedTimer task source. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LayoutProgress timer to UnspecedTimer task source. Based on https://whatwg.org/c/#the-progress-element, there's no specified task source since this is an underlying implementation detail of how the UI is presented. BUG=624694 Review-Url: https://codereview.chromium.org/2650033002 Cr-Commit-Position: refs/heads/master@{#445683} Committed: https://chromium.googlesource.com/chromium/src/+/4b273e243bf047778e36cbc948f72ae13f7934cc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutProgress.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutProgress.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dcheng
3 years, 11 months ago (2017-01-23 23:11:29 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-23 23:53:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650033002/1
3 years, 11 months ago (2017-01-24 08:39:41 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 08:44:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b273e243bf047778e36cbc948f7...

Powered by Google App Engine
This is Rietveld 408576698