Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2650003005: Mark Bluetooth devices connected after they are actually connected (Closed)

Created:
3 years, 11 months ago by juncai
Modified:
3 years, 11 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark Bluetooth devices connected after they are actually connected This CL modified code to mark Bluetooth devices connected when the connection is successful. Also changed the function names to be more descriptive. BUG=684263 Review-Url: https://codereview.chromium.org/2650003005 Cr-Commit-Position: refs/heads/master@{#445865} Committed: https://chromium.googlesource.com/chromium/src/+/e6425162c0931de893c79dc2812ed83c82fb7f07

Patch Set 1 : mark Bluetooth devices connected after they are actually connected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
juncai
Please take a look.
3 years, 11 months ago (2017-01-24 20:25:16 UTC) #4
ortuno
lgtm
3 years, 11 months ago (2017-01-24 22:05:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650003005/1
3 years, 11 months ago (2017-01-24 22:41:37 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 23:55:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e6425162c0931de893c79dc2812e...

Powered by Google App Engine
This is Rietveld 408576698