Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 26500002: Fixes for Valgrind build (Closed)

Created:
7 years, 2 months ago by borenet
Modified:
7 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixes for Valgrind build - Build in Release mode again - Actually use the suppressions files. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11649

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py View 1 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
Waiting to verify the correct behavior on my machine...
7 years, 2 months ago (2013-10-08 15:11:35 UTC) #1
robertphillips
lgtm
7 years, 2 months ago (2013-10-08 15:13:16 UTC) #2
borenet
Patch set 2 is working locally.
7 years, 2 months ago (2013-10-08 15:29:07 UTC) #3
borenet
7 years, 2 months ago (2013-10-08 15:29:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698