Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py

Issue 26500002: Fixes for Valgrind build (Closed) Base URL: http://skia.googlecode.com/svn/buildbot/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
===================================================================
--- slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py (revision 11648)
+++ slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py (working copy)
@@ -14,9 +14,9 @@
def __init__(self, build_step_instance):
DefaultBuildStepUtils.__init__(self, build_step_instance)
classname = self._step.__class__.__name__
- if classname == 'ValgrindRunTests':
+ if classname == 'RunTests':
self._suppressions_file = os.path.join('tests', 'valgrind.supp')
- elif classname == 'ValgrindRunGM':
+ elif classname == 'RunGM':
self._suppressions_file = os.path.join('gm', 'valgrind.supp')
else:
self._suppressions_file = None
@@ -28,18 +28,11 @@
if self._suppressions_file:
cmd.append('--suppressions=%s' % self._suppressions_file)
- # For now, just run in debug mode.
- self._step._configuration = 'Debug'
-
cmd.append(self._PathToBinary(app))
cmd.extend(args)
return shell_utils.Bash(cmd)
def Compile(self, target):
-
- # For now, just run in debug mode.
- self._step._configuration = 'Debug'
-
os.environ['GYP_DEFINES'] = self._step.args['gyp_defines']
print 'GYP_DEFINES="%s"' % os.environ['GYP_DEFINES']
make_cmd = 'make'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698