Added accessor for the ukm service to the browser process singleton

Added accessor for the ukm service to the browser process singleton

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org,sky@chromium.org
BUG=684673
Review-Url: https://codereview.chromium.org/2649983005
Cr-Commit-Position: refs/heads/master@{#445866}
Committed: https://chromium.googlesource.com/chromium/src/+/2fc1646fa5e8434223f2bce7b977fdbb7e2904b6

[oystein (OOO til 10th of July), 2017-01-24 21:34:33]

Description was changed from

==========
Added accessor for the ukm service to the browser process singleton

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org
BUG=684673
==========

to

==========
Added accessor for the ukm service to the browser process singleton

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org,sky@chromium.org
BUG=684673
==========

[oystein (OOO til 10th of July), 2017-01-24 21:34:33]

oysteine@chromium.org changed reviewers:
+ sky@chromium.org

[oystein (OOO til 10th of July), 2017-01-24 21:34:42]

ptal!

[oystein (OOO til 10th of July), 2017-01-24 21:34:48]

The CQ bit was checked by oysteine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 21:35:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Steven Holte, 2017-01-24 21:37:31]

lgtm

[sky, 2017-01-24 22:38:01]

https://codereview.chromium.org/2649983005/diff/40001/chrome/browser/browser_...
File chrome/browser/browser_process.h (right):

https://codereview.chromium.org/2649983005/diff/40001/chrome/browser/browser_...
chrome/browser/browser_process.h:149: virtual ukm::UkmService* ukm_service() =
0;
Can you outline why we need both GetMetricsServicesManager and this accessor,
which appears to be nothing more than a call to
GetMetricsServicesManager()->GetUkmService()?

[oystein (OOO til 10th of July), 2017-01-24 22:44:16]

https://codereview.chromium.org/2649983005/diff/40001/chrome/browser/browser_...
File chrome/browser/browser_process.h (right):

https://codereview.chromium.org/2649983005/diff/40001/chrome/browser/browser_...
chrome/browser/browser_process.h:149: virtual ukm::UkmService* ukm_service() =
0;
On 2017/01/24 22:38:01, sky wrote:
> Can you outline why we need both GetMetricsServicesManager and this accessor,
> which appears to be nothing more than a call to
> GetMetricsServicesManager()->GetUkmService()?

I followed the example of rappor_service() and variations_service(), the main
purpose is to be able to overload it in testing_browser_process.h to return a
unit-test provided subclass of the service.

[sky, 2017-01-24 23:06:41]

Ok, LGTM

[commit-bot: I haz the power, 2017-01-24 23:46:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:46:08]

Dry run: This issue passed the CQ dry run.

[oystein (OOO til 10th of July), 2017-01-24 23:48:26]

The CQ bit was checked by oysteine@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:56:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485301706136610,
"parent_rev": "e6425162c0931de893c79dc2812ed83c82fb7f07", "commit_rev":
"2fc1646fa5e8434223f2bce7b977fdbb7e2904b6"}

[commit-bot: I haz the power, 2017-01-24 23:56:49]

Description was changed from

==========
Added accessor for the ukm service to the browser process singleton

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org,sky@chromium.org
BUG=684673
==========

to

==========
Added accessor for the ukm service to the browser process singleton

Split out from https://codereview.chromium.org/2617883004/

R=holte@chromium.org,sky@chromium.org
BUG=684673

Review-Url: https://codereview.chromium.org/2649983005
Cr-Commit-Position: refs/heads/master@{#445866}
Committed:
https://chromium.googlesource.com/chromium/src/+/2fc1646fa5e8434223f2bce7b977...
==========

[commit-bot: I haz the power, 2017-01-24 23:56:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2fc1646fa5e8434223f2bce7b977...