Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/fields-original.cc

Issue 2649933003: Capitalize WTF-based type traits as lower_case (Closed)
Patch Set: traits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/rewrite_to_chrome_style/tests/fields-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc b/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc
index d2c1b4dc81a68022890d63ea1d910aa46258d650..5f0fda0fdf44a0ab57cd17d1223d4ed43823d120 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/fields-original.cc
@@ -65,10 +65,22 @@ union U {
// https://crbug.com/640749#c1: Some type traits are inside blink namespace.
struct IsGarbageCollectedMixin {
static const bool value = true;
+ static const bool safeToCompareToEmptyOrDeleted = false;
};
} // namespace blink
+namespace not_blink {
+
+// These are traits for WTF types that may be defined outside of blink such
+// as in mojo. But their names are unique so we can globally treat them as
+// type traits for renaming.
+struct GloballyKnownTraits {
+ static const bool safeToCompareToEmptyOrDeleted = false;
+};
+
+} // namespace not_blink
+
namespace WTF {
// We don't want to capitalize fields in type traits
« no previous file with comments | « tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698