Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc

Issue 2649933003: Capitalize WTF-based type traits as lower_case (Closed)
Patch Set: traits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
index e59d5328f82e21b99a6d019bfa36c690bf075bed..89bc554f1a03ce689c70f35ac092c7153cc90dde 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/fields-expected.cc
@@ -68,10 +68,22 @@ union U {
// https://crbug.com/640749#c1: Some type traits are inside blink namespace.
struct IsGarbageCollectedMixin {
static const bool value = true;
+ static const bool safe_to_compare_to_empty_or_deleted = false;
};
} // namespace blink
+namespace not_blink {
+
+// These are traits for WTF types that may be defined outside of blink such
+// as in mojo. But their names are unique so we can globally treat them as
+// type traits for renaming.
+struct GloballyKnownTraits {
+ static const bool safe_to_compare_to_empty_or_deleted = false;
+};
+
+} // namespace not_blink
+
namespace WTF {
// We don't want to capitalize fields in type traits

Powered by Google App Engine
This is Rietveld 408576698