Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2649923015: Convert PrerenderTabHelper to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
pasko
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert PrerenderTabHelper to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2649923015 Cr-Commit-Position: refs/heads/master@{#446352} Committed: https://chromium.googlesource.com/chromium/src/+/23eb09caf3152632a27b7a0ce0a55d1415f0cfe4

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M chrome/browser/prerender/prerender_tab_helper.h View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_tab_helper.cc View 1 2 4 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
jam
3 years, 11 months ago (2017-01-25 23:35:17 UTC) #8
pasko
lgtm, thank you https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerender/prerender_tab_helper.cc File chrome/browser/prerender/prerender_tab_helper.cc (right): https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerender/prerender_tab_helper.cc#newcode55 chrome/browser/prerender/prerender_tab_helper.cc:55: prerender_manager->RecordNavigation(navigation_handle->GetURL()); nit: why not use url_? ...
3 years, 11 months ago (2017-01-26 10:49:03 UTC) #11
jam
https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerender/prerender_tab_helper.cc File chrome/browser/prerender/prerender_tab_helper.cc (right): https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerender/prerender_tab_helper.cc#newcode55 chrome/browser/prerender/prerender_tab_helper.cc:55: prerender_manager->RecordNavigation(navigation_handle->GetURL()); On 2017/01/26 10:49:03, pasko wrote: > nit: why ...
3 years, 11 months ago (2017-01-26 15:50:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649923015/40001
3 years, 11 months ago (2017-01-26 15:51:17 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 16:44:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/23eb09caf3152632a27b7a0ce0a5...

Powered by Google App Engine
This is Rietveld 408576698