Convert PrerenderTabHelper to use the new navigation callbacks.

Convert PrerenderTabHelper to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2649923015
Cr-Commit-Position: refs/heads/master@{#446352}
Committed: https://chromium.googlesource.com/chromium/src/+/23eb09caf3152632a27b7a0ce0a55d1415f0cfe4

[jam, 2017-01-25 16:32:30]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 16:32:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 17:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 17:09:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2017-01-25 22:13:32]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 22:14:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-01-25 23:35:16]

jam@chromium.org changed reviewers:
+ pasko@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 23:47:28]

Dry run: This issue passed the CQ dry run.

[pasko, 2017-01-26 10:49:03]

lgtm, thank you

https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_tab_helper.cc (right):

https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_tab_helper.cc:55:
prerender_manager->RecordNavigation(navigation_handle->GetURL());
nit: why not use url_? methods called in between should not affect the url_

[jam, 2017-01-26 15:50:28]

https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_tab_helper.cc (right):

https://codereview.chromium.org/2649923015/diff/20001/chrome/browser/prerende...
chrome/browser/prerender/prerender_tab_helper.cc:55:
prerender_manager->RecordNavigation(navigation_handle->GetURL());
On 2017/01/26 10:49:03, pasko wrote:
> nit: why not use url_? methods called in between should not affect the url_
I was thrown off by the existing code, but I didn't bother tracing it further.
You're right though, updated.

[jam, 2017-01-26 15:51:03]

The CQ bit was checked by jam@chromium.org

[jam, 2017-01-26 15:51:04]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2649923015/#ps40001
(title: "review comment")

[commit-bot: I haz the power, 2017-01-26 15:51:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 16:44:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485445863864830,
"parent_rev": "21465d6d72621e99b6c25c161db19d3ab0a54fcd", "commit_rev":
"23eb09caf3152632a27b7a0ce0a55d1415f0cfe4"}

[commit-bot: I haz the power, 2017-01-26 16:44:49]

Description was changed from

==========
Convert PrerenderTabHelper to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert PrerenderTabHelper to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2649923015
Cr-Commit-Position: refs/heads/master@{#446352}
Committed:
https://chromium.googlesource.com/chromium/src/+/23eb09caf3152632a27b7a0ce0a5...
==========

[commit-bot: I haz the power, 2017-01-26 16:44:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/23eb09caf3152632a27b7a0ce0a5...