Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2649923008: [foozzie] Disable optimizations for typed float arrays. (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[foozzie] Disable optimizations for typed float arrays. This disables optimizations when using typed float arrays in correctness fuzzer test cases. Otherwise, different NaN patterns in float typed arrays might lead to different observations when using the buffer in an int array view. BUG=chromium:683579 NOTRY=true TBR=Jarin, mvstanton, Igor Sheludko Review-Url: https://codereview.chromium.org/2649923008 Cr-Commit-Position: refs/heads/master@{#42626} Committed: https://chromium.googlesource.com/v8/v8/+/f94c7e8f1a951f6f54a5f629b872404ea9bd16c1

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M tools/foozzie/v8_mock.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Achenbach
PTAL
3 years, 11 months ago (2017-01-24 09:19:49 UTC) #4
Igor Sheludko
lgtm
3 years, 11 months ago (2017-01-24 10:11:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649923008/20001
3 years, 11 months ago (2017-01-24 10:14:05 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 10:15:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f94c7e8f1a951f6f54a5f629b872404ea9b...

Powered by Google App Engine
This is Rietveld 408576698