Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2649903004: kiosk: Allow startup flags for kiosk sessions (Closed)

Created:
3 years, 11 months ago by xiyuan
Modified:
3 years, 11 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Allow startup flags for kiosk sessions Bail in RestartToApplyPerSessionFlagsIfNeed when running in kiosk sessions to allow startup flags be applied. BUG=684015 Review-Url: https://codereview.chromium.org/2649903004 Cr-Commit-Position: refs/heads/master@{#445483} Committed: https://chromium.googlesource.com/chromium/src/+/7c4265c9c4166bbc95b13c5eebae2ed307732857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
xiyuan
3 years, 11 months ago (2017-01-23 19:12:45 UTC) #4
achuithb
browser test for this would be nice. lgtm
3 years, 11 months ago (2017-01-23 19:16:03 UTC) #5
achuithb
browser test for this would be nice. lgtm
3 years, 11 months ago (2017-01-23 19:16:06 UTC) #6
xiyuan
On 2017/01/23 19:16:06, achuithb wrote: > browser test for this would be nice. > > ...
3 years, 11 months ago (2017-01-23 20:59:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649903004/1
3 years, 11 months ago (2017-01-23 21:01:52 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 21:09:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c4265c9c4166bbc95b13c5eebae...

Powered by Google App Engine
This is Rietveld 408576698