Issue 2649903003: [Prerender] Disallow non-standard ports for Google URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2649903003: [Prerender] Disallow non-standard ports for Google URLs

Created:
3 years, 11 months ago by droger

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Prerender] Disallow non-standard ports for Google URLs Non-standard ports were allowed, although this was only useful for testing (because the embedded test server uses such ports). BUG=683853

Patch Set 1 #

Patch Set 2 : cleanup #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
M	chrome/browser/prerender/prerender_histograms.cc	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/prerender/prerender_util.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/prerender/prerender_util_unittest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

droger

The CQ bit was checked by droger@chromium.org to run a CQ dry run

3 years, 11 months ago (2017-01-23 15:21:58 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649903003/1

3 years, 11 months ago (2017-01-23 15:22:02 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 11 months ago (2017-01-23 15:23:12 UTC) #3

commit-bot: I haz the power

3 years, 11 months ago (2017-01-23 15:23:13 UTC) #4

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages