Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 2649903003: [Prerender] Disallow non-standard ports for Google URLs
Patch Set: cleanup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index bfb58c853e0258cd8e9d03c0beee0fc30a8983d0..06ebd97ab7ced02618fc8afed64a673f2729c51c 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -241,9 +241,6 @@ void PrerenderHistograms::RecordPerceivedPageLoadTime(
if (!url.SchemeIsHTTPOrHTTPS())
return;
bool within_window = WithinWindow();
- bool is_google_url =
- google_util::IsGoogleDomainUrl(url, google_util::DISALLOW_SUBDOMAIN,
- google_util::ALLOW_NON_STANDARD_PORTS);
RECORD_PLT("PerceivedPLT", perceived_page_load_time);
if (within_window)
RECORD_PLT("PerceivedPLTWindowed", perceived_page_load_time);
@@ -252,6 +249,9 @@ void PrerenderHistograms::RecordPerceivedPageLoadTime(
seen_any_pageload_ = true;
seen_pageload_started_after_prerender_ = true;
} else if (within_window) {
+ bool is_google_url = google_util::IsGoogleDomainUrl(
+ url, google_util::DISALLOW_SUBDOMAIN,
+ google_util::DISALLOW_NON_STANDARD_PORTS);
if (!is_google_url) {
bool recorded_any = false;
bool recorded_non_overlapping = false;
@@ -300,8 +300,9 @@ void PrerenderHistograms::RecordPageLoadTimeNotSwappedIn(
// If the URL to be prerendered is not a http[s] URL, or is a Google URL,
// do not record.
if (!url.SchemeIsHTTPOrHTTPS() ||
- google_util::IsGoogleDomainUrl(url, google_util::DISALLOW_SUBDOMAIN,
- google_util::ALLOW_NON_STANDARD_PORTS)) {
+ google_util::IsGoogleDomainUrl(
+ url, google_util::DISALLOW_SUBDOMAIN,
+ google_util::DISALLOW_NON_STANDARD_PORTS)) {
return;
}
RECORD_PLT("PrerenderNotSwappedInPLT", page_load_time);
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698