Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2649903002: Content Utility Client: OnUnpackWebResource is not used (Closed)

Created:
3 years, 11 months ago by Noel Gordon
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Content Utility Client: OnUnpackWebResource is not used OnUnpackWebResource() is an orphan declaration. Let's remove it since there is no corresponding definition. BUG=597124 Review-Url: https://codereview.chromium.org/2649903002 Cr-Commit-Position: refs/heads/master@{#446888} Committed: https://chromium.googlesource.com/chromium/src/+/a92d829bc8a9e2c3343010d3691b9da93b7275eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/utility/chrome_content_utility_client.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Noel Gordon
Found another orphan unrelated to my work.
3 years, 11 months ago (2017-01-23 11:42:33 UTC) #3
Sam McNally
lgtm
3 years, 11 months ago (2017-01-24 04:02:30 UTC) #8
Noel Gordon
+ jochen for OWNERS
3 years, 10 months ago (2017-01-27 13:20:28 UTC) #10
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-01-27 15:11:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649903002/1
3 years, 10 months ago (2017-01-28 01:38:30 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 02:33:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a92d829bc8a9e2c3343010d3691b...

Powered by Google App Engine
This is Rietveld 408576698