Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2649873008: Add Bank Name in sync protocol (Closed)

Created:
3 years, 11 months ago by Shanfeng
Modified:
3 years, 10 months ago
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix description of the new field #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/sync/protocol/autofill_specifics.proto View 1 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_visitors.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Shanfeng
3 years, 11 months ago (2017-01-26 20:11:23 UTC) #5
Jared Saul
https://codereview.chromium.org/2649873008/diff/1/components/sync/protocol/autofill_specifics.proto File components/sync/protocol/autofill_specifics.proto (right): https://codereview.chromium.org/2649873008/diff/1/components/sync/protocol/autofill_specifics.proto#newcode127 components/sync/protocol/autofill_specifics.proto:127: // Bank name I'd recommend being a little more ...
3 years, 10 months ago (2017-01-26 20:31:23 UTC) #6
Shanfeng
Thanks for review https://codereview.chromium.org/2649873008/diff/1/components/sync/protocol/autofill_specifics.proto File components/sync/protocol/autofill_specifics.proto (right): https://codereview.chromium.org/2649873008/diff/1/components/sync/protocol/autofill_specifics.proto#newcode127 components/sync/protocol/autofill_specifics.proto:127: // Bank name On 2017/01/26 20:31:23, ...
3 years, 10 months ago (2017-01-26 21:25:02 UTC) #7
Jared Saul
lgtm
3 years, 10 months ago (2017-01-26 21:52:50 UTC) #8
Mathieu
lgtm for this small change. Are you documenting all the changes to be made somewhere?
3 years, 10 months ago (2017-01-26 22:05:01 UTC) #9
Nicolas Zea
lgtm
3 years, 10 months ago (2017-01-27 00:41:00 UTC) #10
Shanfeng
On 2017/01/26 22:05:01, Mathieu Perreault wrote: > lgtm for this small change. Are you documenting ...
3 years, 10 months ago (2017-01-27 18:09:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649873008/20001
3 years, 10 months ago (2017-01-27 18:54:47 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 20:34:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/66660640fd0ed0b4833303450722...

Powered by Google App Engine
This is Rietveld 408576698