Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2649873002: Split some SharedFunctionInfo's compiler hints off into debugger hints. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
Reviewers:
petermarshall
CC:
v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split some SharedFunctionInfo's compiler hints off into debugger hints. We are planning to add a few more debugger related bits, and are running out of compiler hints bits. The new bit field is going to be part of the debug info struct. If the debug info is not available, we store the bit field in its place on the shared function info. Review-Url: https://codereview.chromium.org/2649873002 Cr-Commit-Position: refs/heads/master@{#42594} Committed: https://chromium.googlesource.com/v8/v8/+/3a9152ece721903d3b82e60e8d95f51341183f28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -106 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 3 chunks +3 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/objects.h View 9 chunks +52 lines, -36 lines 0 comments Download
M src/objects-inl.h View 9 chunks +53 lines, -52 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yang
3 years, 11 months ago (2017-01-23 08:39:02 UTC) #2
petermarshall
LGTM!
3 years, 11 months ago (2017-01-23 09:37:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649873002/1
3 years, 11 months ago (2017-01-23 10:23:19 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 10:25:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3a9152ece721903d3b82e60e8d95f513411...

Powered by Google App Engine
This is Rietveld 408576698