Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 2649853003: Make Resource::setResponse() private

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, Yoav Weiss, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Resource::setResponse() private This CL makes setResponse() private and make callers to use responseReceived() instead. This is to make responseReceived() a single point of modification to |m_response| (except for (encoded|decoded)(Body|Data)Length), together with [1]. The only non-test modification is in ImageDocumentParser::finish(). All other changes are unit-test-only. [1] https://codereview.chromium.org/2656443003/ BUG=667641

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp View 1 7 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (12 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-24 02:04:54 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649853003/20001
3 years, 11 months ago (2017-01-24 02:05:48 UTC) #2
hiroshige
Description was changed from ========== Make Resource::setResponse() private In order to centralize modifications of |m_response| ...
3 years, 11 months ago (2017-01-24 02:19:51 UTC) #3
hiroshige
hiroshige@chromium.org changed reviewers: + japhet@chromium.org, kouhei@chromium.org, yhirano@chromium.org
3 years, 11 months ago (2017-01-24 02:19:51 UTC) #4
hiroshige
Description was changed from ========== Make Resource::setResponse() private This CL makes setResponse() private and make ...
3 years, 11 months ago (2017-01-24 02:20:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-24 03:25:11 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/376574)
3 years, 11 months ago (2017-01-24 03:25:11 UTC) #7
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-24 04:15:46 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649853003/20001
3 years, 11 months ago (2017-01-24 04:16:14 UTC) #9
hiroshige
hiroshige@chromium.org changed reviewers: - japhet@chromium.org, kouhei@chromium.org, yhirano@chromium.org
3 years, 11 months ago (2017-01-24 04:17:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-24 05:22:20 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 05:22:20 UTC) #12
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698