Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp

Issue 2649853003: Make Resource::setResponse() private
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/RawResource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp b/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
index baefbba4fcacdc8a30ea4bbb61de0a3f4acff98a..1742c0ffcc44be73c5190670ee265cffc23daf9f 100644
--- a/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/MemoryCacheCorrectnessTest.cpp
@@ -62,7 +62,7 @@ class MemoryCacheCorrectnessTest : public ::testing::Test {
response.setURL(KURL(ParsedURLString, kResourceURL));
MockResource* resource =
MockResource::create(ResourceRequest(response.url()));
- resource->setResponse(response);
+ resource->responseReceived(response, nullptr);
resource->finish();
memoryCache()->add(resource);
@@ -72,8 +72,10 @@ class MemoryCacheCorrectnessTest : public ::testing::Test {
if (request.url().isNull())
request.setURL(KURL(ParsedURLString, kResourceURL));
MockResource* resource = MockResource::create(request);
- resource->setResponse(ResourceResponse(KURL(ParsedURLString, kResourceURL),
- "text/html", 0, nullAtom, String()));
+ resource->responseReceived(
+ ResourceResponse(KURL(ParsedURLString, kResourceURL), "text/html", 0,
+ nullAtom, String()),
+ nullptr);
resource->finish();
memoryCache()->add(resource);
@@ -373,7 +375,7 @@ TEST_F(MemoryCacheCorrectnessTest, FreshWithFreshRedirect) {
fresh200Response.setHTTPHeaderField(HTTPNames::Expires,
kOneDayAfterOriginalRequest);
- firstResource->setResponse(fresh200Response);
+ firstResource->responseReceived(fresh200Response, nullptr);
firstResource->finish();
memoryCache()->add(firstResource);
@@ -412,7 +414,7 @@ TEST_F(MemoryCacheCorrectnessTest, FreshWithStaleRedirect) {
fresh200Response.setHTTPHeaderField(HTTPNames::Expires,
kOneDayAfterOriginalRequest);
- firstResource->setResponse(fresh200Response);
+ firstResource->responseReceived(fresh200Response, nullptr);
firstResource->finish();
memoryCache()->add(firstResource);
@@ -470,7 +472,7 @@ TEST_F(MemoryCacheCorrectnessTest, 302RedirectNotImplicitlyFresh) {
fresh200Response.setHTTPHeaderField(HTTPNames::Expires,
kOneDayAfterOriginalRequest);
- firstResource->setResponse(fresh200Response);
+ firstResource->responseReceived(fresh200Response, nullptr);
firstResource->finish();
memoryCache()->add(firstResource);
@@ -510,7 +512,7 @@ TEST_F(MemoryCacheCorrectnessTest, 302RedirectExplicitlyFreshMaxAge) {
fresh200Response.setHTTPHeaderField(HTTPNames::Expires,
kOneDayAfterOriginalRequest);
- firstResource->setResponse(fresh200Response);
+ firstResource->responseReceived(fresh200Response, nullptr);
firstResource->finish();
memoryCache()->add(firstResource);
@@ -551,7 +553,7 @@ TEST_F(MemoryCacheCorrectnessTest, 302RedirectExplicitlyFreshExpires) {
fresh200Response.setHTTPHeaderField(HTTPNames::Expires,
kOneDayAfterOriginalRequest);
- firstResource->setResponse(fresh200Response);
+ firstResource->responseReceived(fresh200Response, nullptr);
firstResource->finish();
memoryCache()->add(firstResource);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/RawResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698