Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2649843002: X87: Skip SignallingNanSurvivesI32ReinterpretF32/SignallingNanSurvivesI64ReinterpretF64 tests. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
titzer, chunyang.dai, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Skip SignallingNanSurvivesI32ReinterpretF32/SignallingNanSurvivesI64ReinterpretF64 tests. The CL #42545 (https://codereview.chromium.org/2639353002 ) add SignallingNanSurvivesI32ReinterpretF32/SignallingNanSurvivesI64ReinterpretF64 tests. Those tests failed at x87 port as X87 FPU hardware will convert a sNaN to qNaN automatically. This CL skips SignallingNanSurvivesI32ReinterpretF32/SignallingNanSurvivesI64ReinterpretF64 tests for x87. BUG= Review-Url: https://codereview.chromium.org/2649843002 Cr-Commit-Position: refs/heads/master@{#42591} Committed: https://chromium.googlesource.com/v8/v8/+/6435c2343ccaf928b0ecb9dedbcea65394e8b037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/cctest/cctest.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 07:13:16 UTC) #2
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 07:14:51 UTC) #4
ahaas
lgtm
3 years, 11 months ago (2017-01-23 08:18:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649843002/1
3 years, 11 months ago (2017-01-23 08:40:00 UTC) #7
chunyang.dai
On 2017/01/23 08:40:00, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-23 08:41:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/6435c2343ccaf928b0ecb9dedbcea65394e8b037
3 years, 11 months ago (2017-01-23 09:10:59 UTC) #11
titzer
On 2017/01/23 09:10:59, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-23 09:23:35 UTC) #12
zhengxing.li
On 2017/01/23 09:23:35, titzer wrote: > On 2017/01/23 09:10:59, commit-bot: I haz the power wrote: ...
3 years, 11 months ago (2017-01-23 09:36:33 UTC) #13
titzer
3 years, 11 months ago (2017-01-23 10:11:48 UTC) #14
Message was sent while issue was closed.
On 2017/01/23 09:36:33, zhengxing.li wrote:
> On 2017/01/23 09:23:35, titzer wrote:
> > On 2017/01/23 09:10:59, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/v8/v8/+/6435c2343ccaf928b0ecb9dedbcea65394e...
> > 
> > Any insight on how to fix this correctly on x87? It's part of the WASM spec.
> 
> Hi, Titzer:
> 
> This issue bothers me for a long time. But I have no good way to fix it in a
> short time. I will still follow this issue and fix it once I get a good idea
> about it.
> 
> Thanks!

Thanks, as long as it is on your radar.

Powered by Google App Engine
This is Rietveld 408576698