Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2649783002: Move CanvasRenderingContext2D timer to frame-specific TaskRunnerTimer. (Closed)

Created:
3 years, 11 months ago by Byoungkwon Ko
Modified:
3 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, ajuma+watch-canvas_chromium.org, dshwang, Justin Novosad, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CanvasRenderingContext2D timer to frame-specific TaskRunnerTimer. Move CanvasRenderingContext2D timers to frame-specific TaskRunnerTimer. This associates it with the frame's CanvasBlobSerialization timer task queue. The spec link: https://html.spec.whatwg.org/multipage/scripting.html#canvasrenderingcontext2d This CL is migrating tasks/timers from a per-renderer scheduler to a per-frame scheduler: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/80dsbEEOcWY BUG=624694 Review-Url: https://codereview.chromium.org/2649783002 Cr-Commit-Position: refs/heads/master@{#448268} Committed: https://chromium.googlesource.com/chromium/src/+/0a80c26dfe96dc2ac2233c0840fe10bbb3c67dad

Patch Set 1 #

Patch Set 2 : Move CanvasRenderingContext2D timer to frame-specific TaskRunnerTimer. #

Patch Set 3 : Move CanvasRenderingContext2D timer to frame-specific TaskRunnerTimer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Byoungkwon Ko
PTAL Haraken@
3 years, 10 months ago (2017-02-05 17:13:23 UTC) #10
haraken
I think we should use MiscPlatformAPI for this. With that change, LGTM. - As far ...
3 years, 10 months ago (2017-02-06 00:37:20 UTC) #13
Byoungkwon Ko
On 2017/02/06 00:37:20, haraken wrote: > I think we should use MiscPlatformAPI for this. With ...
3 years, 10 months ago (2017-02-06 14:41:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649783002/40001
3 years, 10 months ago (2017-02-06 14:42:27 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 16:24:22 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0a80c26dfe96dc2ac2233c0840fe...

Powered by Google App Engine
This is Rietveld 408576698