Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2649773009: Add .gitignore to ShowGlobals directory (Closed)

Created:
3 years, 11 months ago by brucedawson
Modified:
3 years, 11 months ago
Reviewers:
stanisc
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add .gitignore to ShowGlobals directory Building ShowGlobals causes dirty files to show up in git status. This is unwanted. R=stanisc@chromium.org Review-Url: https://codereview.chromium.org/2649773009 Cr-Commit-Position: refs/heads/master@{#446100} Committed: https://chromium.googlesource.com/chromium/src/+/24439f5819c904b12f454103bd8c8c73c9d31cc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A tools/win/ShowGlobals/.gitignore View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brucedawson
Oops - I forgot to add this initially.
3 years, 11 months ago (2017-01-25 02:00:13 UTC) #1
stanisc
lgtm
3 years, 11 months ago (2017-01-25 18:26:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649773009/1
3 years, 11 months ago (2017-01-25 18:36:25 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 20:08:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/24439f5819c904b12f454103bd8c...

Powered by Google App Engine
This is Rietveld 408576698