Collect module information from the stability file

Collect module information from the stability file

BUG=620813
Review-Url: https://codereview.chromium.org/2649773008
Cr-Commit-Position: refs/heads/master@{#446808}
Committed: https://chromium.googlesource.com/chromium/src/+/cfefdd7db190a5161e39488c1f09e36635f7b8d4

[manzagop (departed), 2017-01-25 19:52:06]

manzagop@chromium.org changed reviewers:
+ bcwhite@chromium.org, scottmg@chromium.org

[manzagop (departed), 2017-01-25 19:52:07]

Here's module collection. Please have a look!

[manzagop (departed), 2017-01-25 19:54:30]

manzagop@chromium.org changed reviewers:
- scottmg@chromium.org

[manzagop (departed), 2017-01-25 19:54:30]

Oops, Scott to cc as accidentally added. Unless you want to have a quick peek at
the computing the code / debug identifiers. I took what I found in crashpad.

[scottmg, 2017-01-25 20:16:54]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2017-01-25 20:16:55]

lgtm

[manzagop (departed), 2017-01-26 22:31:21]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:32:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-01-26 22:33:27]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 22:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 23:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 23:16:00]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[manzagop (departed), 2017-01-27 14:45:01]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 14:45:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 15:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 15:58:00]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[manzagop (departed), 2017-01-27 16:24:45]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 16:25:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 17:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 17:38:44]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[manzagop (departed), 2017-01-27 18:32:32]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 18:33:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[manzagop (departed), 2017-01-27 18:38:17]

Brian, does this lgty?

[bcwhite, 2017-01-27 18:48:26]

LGTM % nits

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
File components/browser_watcher/postmortem_report_collector.cc (right):

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector.cc:107:
snprintf(code_identifier, sizeof(code_identifier), "%08X%zx",
%08X%zX (both Xs capitalized) for consistency
Do you want dash separators or something to make it easier to parse visually?

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector.cc:115:
"%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X%x", uuid->data_1,
Last X should be capitalized.
Same comment about dash separators.

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
File components/browser_watcher/postmortem_report_collector_unittest.cc (right):

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector_unittest.cc:660: //
Validate the report's log content.
modules content

[manzagop (departed), 2017-01-27 19:25:07]

The CQ bit was checked by manzagop@chromium.org to run a CQ dry run

[manzagop (departed), 2017-01-27 19:25:22]

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
File components/browser_watcher/postmortem_report_collector.cc (right):

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector.cc:107:
snprintf(code_identifier, sizeof(code_identifier), "%08X%zx",
On 2017/01/27 18:48:26, bcwhite wrote:
> %08X%zX (both Xs capitalized) for consistency
> Do you want dash separators or something to make it easier to parse visually?

This actually is the specification for the identifier. I placed a comment to say
we need this exact formatting.

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector.cc:115:
"%08X%04X%04X%02X%02X%02X%02X%02X%02X%02X%02X%x", uuid->data_1,
On 2017/01/27 18:48:26, bcwhite wrote:
> Last X should be capitalized.
> Same comment about dash separators.

Same as above.

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
File components/browser_watcher/postmortem_report_collector_unittest.cc (right):

https://codereview.chromium.org/2649773008/diff/100001/components/browser_wat...
components/browser_watcher/postmortem_report_collector_unittest.cc:660: //
Validate the report's log content.
On 2017/01/27 18:48:26, bcwhite wrote:
> modules content

Done.

[commit-bot: I haz the power, 2017-01-27 19:25:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-01-27 20:05:46]

lgtm

[commit-bot: I haz the power, 2017-01-27 20:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:25:29]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[manzagop (departed), 2017-01-27 21:57:25]

Thanks for the review!

[manzagop (departed), 2017-01-27 21:57:30]

The CQ bit was checked by manzagop@chromium.org

[manzagop (departed), 2017-01-27 21:57:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, bcwhite@chromium.org
Link to the patchset: https://codereview.chromium.org/2649773008/#ps140001
(title: "YA signed/unsigned")

[commit-bot: I haz the power, 2017-01-27 21:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 22:49:40]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1485554250564950,
"parent_rev": "7bea51146249f12bb9b6af2a7113701033b2a334", "commit_rev":
"cfefdd7db190a5161e39488c1f09e36635f7b8d4"}

[commit-bot: I haz the power, 2017-01-27 22:50:16]

Description was changed from

==========
Collect module information from the stability file

BUG=620813
==========

to

==========
Collect module information from the stability file

BUG=620813

Review-Url: https://codereview.chromium.org/2649773008
Cr-Commit-Position: refs/heads/master@{#446808}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfefdd7db190a5161e39488c1f09...
==========

[commit-bot: I haz the power, 2017-01-27 22:50:17]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/cfefdd7db190a5161e39488c1f09...