Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2649773006: Use explicit WebString conversions in renderer/net/net_error_helper.cc (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in renderer/net/net_error_helper.cc As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 Review-Url: https://codereview.chromium.org/2649773006 Cr-Commit-Position: refs/heads/master@{#445891} Committed: https://chromium.googlesource.com/chromium/src/+/671a5e16b18fd2229be6d30fb66a9b4e05640a5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/renderer/net/net_error_helper.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kinuko
Tiny one-liner change only. Could you take a look?
3 years, 11 months ago (2017-01-24 14:13:34 UTC) #3
mmenke
On 2017/01/24 14:13:34, kinuko wrote: > Tiny one-liner change only. Could you take a look? ...
3 years, 11 months ago (2017-01-24 16:03:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649773006/1
3 years, 11 months ago (2017-01-25 01:03:02 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 01:12:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/671a5e16b18fd2229be6d30fb66a...

Powered by Google App Engine
This is Rietveld 408576698