Add an issue tracker COMPONENT annotation to content_settings/

Add an issue tracker COMPONENT annotation to content_settings/

Content settings issues should be generally flagged to Privacy
and Security teams.

BUG=None

Review-Url: https://codereview.chromium.org/2649773005
Cr-Commit-Position: refs/heads/master@{#447759}
Committed: https://chromium.googlesource.com/chromium/src/+/c68745ecea0b6c871f8a924b1d6009d93c9ff073

[msramek, 2017-01-24 14:04:16]

msramek@chromium.org changed reviewers:
+ raymes@chromium.org

[msramek, 2017-01-24 14:04:17]

Hi Raymes!

I just noticed that we don't have the component annotation in our OWNERS file
(seems to be popular nowadays :) ). I don't know what to add from your side,
though? Team-Security-UX is a label, not a component. Please advise :)

Cheers,
Martin

[raymes, 2017-01-24 23:59:08]

On 2017/01/24 14:04:17, msramek wrote:
> Hi Raymes!
> 
> I just noticed that we don't have the component annotation in our OWNERS file
> (seems to be popular nowadays :) ). I don't know what to add from your side,
> though? Team-Security-UX is a label, not a component. Please advise :)
> 
> Cheers,
> Martin

The component could be Internals>Permissions>Model and the team
chrome-permissions-team@google.com.

Are multiple components allowed?

[raymes, 2017-01-24 23:59:18]

On 2017/01/24 23:59:08, raymes wrote:
> On 2017/01/24 14:04:17, msramek wrote:
> > Hi Raymes!
> > 
> > I just noticed that we don't have the component annotation in our OWNERS
file
> > (seems to be popular nowadays :) ). I don't know what to add from your side,
> > though? Team-Security-UX is a label, not a component. Please advise :)
> > 
> > Cheers,
> > Martin
> 
> The component could be Internals>Permissions>Model and the team
> mailto:chrome-permissions-team@google.com.
> 
> Are multiple components allowed?

(Thanks for looking at this btw :)

[msramek, 2017-01-26 17:34:54]

The CQ bit was checked by msramek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 17:35:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msramek, 2017-01-26 17:42:47]

On 2017/01/24 23:59:18, raymes wrote:
> On 2017/01/24 23:59:08, raymes wrote:
> > On 2017/01/24 14:04:17, msramek wrote:
> > > Hi Raymes!
> > > 
> > > I just noticed that we don't have the component annotation in our OWNERS
> file
> > > (seems to be popular nowadays :) ). I don't know what to add from your
side,
> > > though? Team-Security-UX is a label, not a component. Please advise :)
> > > 
> > > Cheers,
> > > Martin
> > 
> > The component could be Internals>Permissions>Model and the team
> > mailto:chrome-permissions-team@google.com.

Done, but I want to confirm that you're sure about that. I vaguely remember that
@google.com mailinglists were sort-of discouraged due to the open-source nature
of the project. Conversely, does that mailinglist accept external traffic?

> > 
> > Are multiple components allowed?

According to PRESUBMIT, no. Well... I guess it makes more sense for
Permissions>Model to be there than Privacy (grumble grumble).

> 
> (Thanks for looking at this btw :)

np :)

[commit-bot: I haz the power, 2017-01-26 17:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-26 17:49:03]

Dry run: This issue passed the CQ dry run.

[raymes, 2017-02-01 22:52:55]

On 2017/01/26 17:42:47, msramek wrote:
> On 2017/01/24 23:59:18, raymes wrote:
> > On 2017/01/24 23:59:08, raymes wrote:
> > > On 2017/01/24 14:04:17, msramek wrote:
> > > > Hi Raymes!
> > > > 
> > > > I just noticed that we don't have the component annotation in our OWNERS
> > file
> > > > (seems to be popular nowadays :) ). I don't know what to add from your
> side,
> > > > though? Team-Security-UX is a label, not a component. Please advise :)
> > > > 
> > > > Cheers,
> > > > Martin
> > > 
> > > The component could be Internals>Permissions>Model and the team
> > > mailto:chrome-permissions-team@google.com.
> 
> Done, but I want to confirm that you're sure about that. I vaguely remember
that
> @google.com mailinglists were sort-of discouraged due to the open-source
nature
> of the project. Conversely, does that mailinglist accept external traffic?

Good point. In that case we probably don't have a list to add right now but I'll
investigate it.

Besides that, lgtm!

> 
> > > 
> > > Are multiple components allowed?
> 
> According to PRESUBMIT, no. Well... I guess it makes more sense for
> Permissions>Model to be there than Privacy (grumble grumble).
> 
> > 
> > (Thanks for looking at this btw :)
> 
> np :)

[msramek, 2017-02-02 13:30:22]

Alright, then I'll add just the COMPONENTs for now. Thanks!

[msramek, 2017-02-02 13:30:26]

The CQ bit was checked by msramek@chromium.org

[msramek, 2017-02-02 13:30:26]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2649773005/#ps40001
(title: "Just COMPONENTs.")

[commit-bot: I haz the power, 2017-02-02 13:30:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 14:01:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486042226205220,
"parent_rev": "d9b697d8c200121d64e06826551450a3d7c7b68c", "commit_rev":
"c68745ecea0b6c871f8a924b1d6009d93c9ff073"}

[commit-bot: I haz the power, 2017-02-02 14:01:38]

Description was changed from

==========
Add an issue tracker COMPONENT annotation to content_settings/

Content settings issues should be generally flagged to Privacy
and Security teams.

BUG=None
==========

to

==========
Add an issue tracker COMPONENT annotation to content_settings/

Content settings issues should be generally flagged to Privacy
and Security teams.

BUG=None

Review-Url: https://codereview.chromium.org/2649773005
Cr-Commit-Position: refs/heads/master@{#447759}
Committed:
https://chromium.googlesource.com/chromium/src/+/c68745ecea0b6c871f8a924b1d60...
==========

[commit-bot: I haz the power, 2017-02-02 14:01:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c68745ecea0b6c871f8a924b1d60...