Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2649743002: Merged: [wasm] WebAssembly.Memory.grow() should handle the no instance case - Currently WebAsse ... (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [wasm] WebAssembly.Memory.grow() should handle the no instance case - Currently WebAsse ... Revision: 6934db7ca7777db0799ec76b3fae811734e3c5c2 BUG=chromium:680938 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=hablich@chromium.org,gdeepti@chromium.org Review-Url: https://codereview.chromium.org/2649743002 . Cr-Commit-Position: refs/branch-heads/5.7@{#16} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/72fa37e561aea615a2af03ecbefd791b4e8e76d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -36 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +23 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 2 chunks +37 lines, -18 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-680938.js View 1 chunk +8 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 1 chunk +13 lines, -10 lines 0 comments Download
M test/mjsunit/wasm/memory.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bradnelson
3 years, 11 months ago (2017-01-21 20:03:09 UTC) #1
bradnelson
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-21 20:03:10 UTC) #2
bradnelson
3 years, 11 months ago (2017-01-21 20:06:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
72fa37e561aea615a2af03ecbefd791b4e8e76d5.

Powered by Google App Engine
This is Rietveld 408576698