Issue 264973020: Replace NewFunction(MaybeHandle<> prototype by Handle<> prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264973020: Replace NewFunction(MaybeHandle<> prototype by Handle<> prototype (Closed)

Created:
6 years, 7 months ago by Toon Verwaest

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Replace NewFunction(MaybeHandle<> prototype by Handle<> prototype BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21237

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -70 lines)			Patch
M	src/bootstrapper.cc	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
M	src/factory.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/factory.cc	View	1	3 chunks	+49 lines, -56 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Igor Sheludko

I missed this CL while I was reviewing "270573003: Rename NewFunction without prototype to NewFunctionWithoutPrototype". ...

6 years, 7 months ago (2014-05-07 19:01:51 UTC) #1

Toon Verwaest

6 years, 7 months ago (2014-05-09 16:59:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r21237 (presubmit successful).