src/factory.h - Issue 264973020: Replace NewFunction(MaybeHandle<> prototype by Handle<> prototype

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.h

Issue 264973020: Replace NewFunction(MaybeHandle<> prototype by Handle<> prototype (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.h

diff --git a/src/factory.h b/src/factory.h

index 52f92717f585600e85e8efc9314c52aab033c3ec..02d0044c36562e9f03d41857e9840154f914a562 100644

--- a/src/factory.h

+++ b/src/factory.h

@@ -452,8 +452,9 @@ class Factory V8_FINAL {

void BecomeJSFunction(Handle<JSReceiver> object);

Handle<JSFunction> NewFunction(Handle<String> name,

- MaybeHandle<Object> maybe_prototype,

- MaybeHandle<Code> maybe_code);

+ MaybeHandle<Code> maybe_code,

+ MaybeHandle<Object> maybe_prototype =

+ MaybeHandle<Object>());

Handle<JSFunction> NewFunction(Handle<String> name);

Handle<JSFunction> NewFunctionFromSharedFunctionInfo(

@@ -461,7 +462,7 @@ class Factory V8_FINAL {

Handle<Context> context,

PretenureFlag pretenure = TENURED);

- Handle<JSFunction> NewFunction(MaybeHandle<Object> maybe_prototype,

+ Handle<JSFunction> NewFunction(Handle<Object> maybe_prototype,

Handle<String> name,

InstanceType type,

int instance_size,

« no previous file with comments | « src/bootstrapper.cc ('k') | src/factory.cc » ('j') | no next file with comments »