Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 264973014: Relocate suspended generator activations when enabling debug mode (Closed)

Created:
6 years, 7 months ago by wingo
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Relocate suspended generator activations when enabling debug mode R=yangguo@chromium.org BUG=v8:3289 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -72 lines) Patch
M src/debug.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug.cc View 8 chunks +170 lines, -72 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/generators-relocation.js View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
6 years, 7 months ago (2014-05-05 13:49:42 UTC) #1
wingo
The difference between this and r21141 is a static_cast<int>(Address - Address) in debug.cc.
6 years, 7 months ago (2014-05-05 13:56:24 UTC) #2
Yang
On 2014/05/05 13:56:24, wingo wrote: > The difference between this and r21141 is a static_cast<int>(Address ...
6 years, 7 months ago (2014-05-05 14:05:08 UTC) #3
wingo
6 years, 7 months ago (2014-05-05 14:32:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698