Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 264963007: Fix MonitoredVideoStubTest failure in memory runs (Closed)

Created:
6 years, 7 months ago by kelvinp
Modified:
6 years, 7 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Fix MonitoredVideoStubTest failure in memory runs Cause: The test fails because on slow machines, the connectivity check timer may fires before the test finishes. As a result, there is an unexpected transition to not ready on the video channel. Fix: Take that transition into account. BUG=369191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267773

Patch Set 1 : Fix MonitoredVideoStubTest failure in memory runs #

Total comments: 2

Patch Set 2 : Address Jamie's feedbacks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M remoting/protocol/monitored_video_stub_unittest.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/remoting_unittests.gtest.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kelvinp
6 years, 7 months ago (2014-05-02 00:55:03 UTC) #1
Jamie
lgtm https://codereview.chromium.org/264963007/diff/20001/remoting/protocol/monitored_video_stub_unittest.cc File remoting/protocol/monitored_video_stub_unittest.cc (right): https://codereview.chromium.org/264963007/diff/20001/remoting/protocol/monitored_video_stub_unittest.cc#newcode50 remoting/protocol/monitored_video_stub_unittest.cc:50: // On slow machines, the connectivity check timer ...
6 years, 7 months ago (2014-05-02 01:06:32 UTC) #2
kelvinp
https://codereview.chromium.org/264963007/diff/20001/remoting/protocol/monitored_video_stub_unittest.cc File remoting/protocol/monitored_video_stub_unittest.cc (right): https://codereview.chromium.org/264963007/diff/20001/remoting/protocol/monitored_video_stub_unittest.cc#newcode50 remoting/protocol/monitored_video_stub_unittest.cc:50: // On slow machines, the connectivity check timer may ...
6 years, 7 months ago (2014-05-02 01:11:14 UTC) #3
kelvinp
The CQ bit was checked by kelvinp@chromium.org
6 years, 7 months ago (2014-05-02 01:11:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kelvinp@chromium.org/264963007/40001
6 years, 7 months ago (2014-05-02 01:11:55 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 09:44:29 UTC) #6
Message was sent while issue was closed.
Change committed as 267773

Powered by Google App Engine
This is Rietveld 408576698